pushgateway icon indicating copy to clipboard operation
pushgateway copied to clipboard

Push an abridged README to Docker Hub

Open beorn7 opened this issue 1 year ago • 3 comments

The full README.md exceeds the character limit for the description on Docker Hub. This commit pushes an abridged README-docker.md to Docker Hub. It contains a reference to the full README.md.

beorn7 avatar May 22 '24 13:05 beorn7

Maybe we should move some of the text to other documentation files?

SuperQ avatar May 22 '24 14:05 SuperQ

So far, having all the documentation for a relatively simple app just in README.md served us well. Maybe it's time to move on to "real" documentation, but I don't want this to be motivated by a character limit on Docker Hub in combination with the inflexibility of our tooling.

beorn7 avatar May 22 '24 14:05 beorn7

Is there some way to implement an override for the GH actions? Should we create one?

beorn7 avatar May 22 '24 14:05 beorn7

Here is an idea: readme_file: 'README.md' is the default behavior anyway, so we could just leave it out. This has the additional twist that the tool will prefer a file called README-containers.md if it exists. (At least that's how I understand https://github.com/christian-korneck/docker-pushrm .) This behavior seems to be precisely tailored to the use case at hand here.

So plan would be:

  1. Remove readme_file: 'README.md' from the source in prometheus/prometheus.
  2. Let it propagate.
  3. Rename README-docker.md in this PR to README-containers.md (and revert the other changes).

Only drawback is that it will deliver the shorter README also to Quay (which apparently allows larger descriptions), but I guess that's fine.

WDYT?

beorn7 avatar May 23 '24 12:05 beorn7

@SuperQ what do you think about the idea above?

beorn7 avatar Jun 04 '24 10:06 beorn7

Chatted with @SuperQ , and the plan seems to work.

https://github.com/prometheus/prometheus/pull/14211 is merged for step 1. We have to wait until it has propagated (step 2), and then I will change this PR to implement step 3.

beorn7 avatar Jun 04 '24 15:06 beorn7

Updated according to the new plan. @SuperQ PHAL.

beorn7 avatar Jun 05 '24 11:06 beorn7