promu Use env var GO if available

Use env var GO if available

Open sylr opened this issue 5 years ago • 5 comments

Allows you to compile with a different GO toolchain when you have several version installed on your system.

Feb 08 '20 09:02 sylr

I'd rather have it as a flag of the build command.

Feb 14 '20 17:02 simonpasquier

I'd rather have it as a flag of the build command.

In general we indeed avoid using env variables

Feb 15 '20 17:02 roidelapluie

I wanted to stay in sync with the Makefiles https://github.com/prometheus/promu/blob/2e745da3feab32c483524de1b78efbffe13e9334/Makefile#L19

Feb 15 '20 17:02 sylr

Maybe the makefile could do promu --gobin $GO, WDYT? And the does not resolve the issue with $go enerate and custom $GO, doe it?

Feb 15 '20 17:02 roidelapluie

I agree with @roidelapluie. IMO it's cleaner to let the Makefile invoke promu build --gobin $(GO).

Feb 17 '20 12:02 simonpasquier