prometheus
tsdb/agent: Prevent unread segments from being truncated
Proposal
Today the tsdb/agent truncates the the WAL segments based on the assumption, https://github.com/prometheus/prometheus/blob/f50ff0a40ad4ef24d9bb8e81a6546c8c994a924a/tsdb/agent/db.go#L676 which is not verified before truncation occurs.
Due to this it's really hard to determine how much downtime can be tolerated in a remote write configuration since it's a factor of TruncateFrequency + rate of data in. This leads to a much higherTruncateFrequencythan is really necessary and much larger WALs that must be fully replayed on startup. Internally we run with a 15 minute interval as we are okay with trading off downtime tolerance for less memory usage.
I would propose remote.Storage expose the ability to subscribe to be notified when a segment changes. This would be called after all current queues have read past a segment, sample implementation.
After segment notifications are working the tsdb/agent could subscribe and truncate based on segments that have been fully read. At this point we could consider dropping the default TruncateFrequency allowing for smaller WALs.
I'm not sure how much of this, if any, is applicable for tsdb/db or head
Hello from the bug scrub!
@aviralgarg05 let's first get some idea if this is the right way to go and how it should look like in detail.
@jesusvazquez what do you think about this?
