prometheus icon indicating copy to clipboard operation
prometheus copied to clipboard

maraphon.go: Simplified conditions in method

Open proggga opened this issue 2 years ago • 3 comments

Small improvement, hope you are hacktoberfest friendly =) Thanks

proggga avatar Oct 14 '22 23:10 proggga

I need someone to help me with this broken pipeline

proggga avatar Oct 20 '22 12:10 proggga

I wonder if everything needs to be put down under a if or if we should adapt the exiting ifs with the variable

roidelapluie avatar Oct 21 '22 12:10 roidelapluie

I wonder if everything needs to be put down under a if or if we should adapt the exiting ifs with the variable

I can make any option, as you want, because I'm not a familiar with style in this repo

proggga avatar Oct 22 '22 13:10 proggga

We have discussed this during our bug scrub. Are you still willing to work on this @proggga ?

We'd like to suggest to use a switch inside the if condition and avoid creating an extra variable (just for one usage).

roidelapluie avatar Jul 11 '23 11:07 roidelapluie

Yep, I'll do this, need few days to find time, but I'll do this

proggga avatar Jul 12 '23 08:07 proggga

@roidelapluie Can you please take a look once again when you have free time, thanks for your help!

proggga avatar Jul 13 '23 18:07 proggga

Thanks!

roidelapluie avatar Aug 14 '23 13:08 roidelapluie