procfs icon indicating copy to clipboard operation
procfs copied to clipboard

add cpuinfo for loongarch64

Open zhangwenlong8911 opened this issue 3 years ago • 11 comments

zhangwenlong8911 avatar May 27 '21 03:05 zhangwenlong8911

@SuperQ Hello, I added cpuinfo for loongarch64, at the same time I have compiled and tested locally, and have used the codes in other projects without any problems. can you help me to review the code? Thank you

zhangwenlong8911 avatar Jun 01 '21 16:06 zhangwenlong8911

Thanks, I'll take a look at this soon.

SuperQ avatar Jun 01 '21 16:06 SuperQ

Oh exciting! I don't think it's possible to get loongarch64 systems anywhere yet, right? Or do you know a way? So I can't really verify this..

discordianfish avatar Jun 08 '21 10:06 discordianfish

loongarch64 is a new system, and command “make test” in loongarch64 is ok, I can provide a screenshot of the result

procfs构建结果

1111111

zhangwenlong8911 avatar Jun 09 '21 03:06 zhangwenlong8911

The LoongArch kernel support hasn't been upstream yet; even the first submission is yet to appear. So in theory the /proc/cpuinfo format could change; I suggest we wait for the moment, and only revise and merge after the kernel bits get upstreamed.

xen0n avatar Jun 09 '21 03:06 xen0n

I'm fine either way, merging this also wouldn't break anything so..

@zhangwenlong8911 Do you know if I can buy a loongarch64 system somewhere online? Or how did you get your hands on one?

discordianfish avatar Jul 01 '21 09:07 discordianfish

FYI, the initial LoongArch kernel bits appeared; but it's still long before being mainlined, so technically things could still change. For now the /proc/cpuinfo format is very much MIPS-like, and I doubt it would persist into the final version.

xen0n avatar Jul 01 '21 09:07 xen0n

@discordianfish I am a member of the loongarch64 team, so I can get first-hand information, LoongArch kernel support has been submitted to the kernel community

zhangwenlong8911 avatar Jul 05 '21 01:07 zhangwenlong8911

+1 for consistency, if it's called 'loong(64)' in golang, let's do it here as well.

discordianfish avatar Dec 13 '21 09:12 discordianfish

I think you are right@xen0n @discordianfish, I modify the architecture information now, about / proc / cpuinfo, let's wait

zhangwenlong8911 avatar Dec 13 '21 11:12 zhangwenlong8911

Finally, please add Signed-off-by line. (see that failing DCO check?)

While at it, modify your PR title and commit message so LoongArch64 is uniformly referred to as loong64 in the Go ecosystem.

xen0n avatar Aug 05 '22 06:08 xen0n

Go 1.19 finally supports this platform.

SuperQ avatar Dec 17 '22 19:12 SuperQ