diskstats_linux.go: add collector.diskstats.disable-queue-stats flag

Open wjordan opened this issue 1 year ago • 2 comments

Adds a flag to skip the call to SysBlockDeviceQueueStats in the diskstats collector, to improve performance over a large number of devices when the extra rotational label is not needed on the info metric.

Fixes #3282.

I don't have a strong preference on the naming or default, as long as it can be configured. In the PR, I named it collector.diskstats.disable-queue-stats defaulting to false, since this is probably an uncommon issue affecting systems with many (thousands) of block devices.

Mar 26 '25 22:03 wjordan

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Mar 27 '25 09:03 SuperQ

Ping, are you able to finish this work?

Mar 31 '25 04:03 SuperQ