node_exporter icon indicating copy to clipboard operation
node_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

Skip over the zfs IO metrics if their paths are missing

Open tnextday opened this issue 2 years ago • 3 comments

Resolves #2068

Signed-off-by: tnextday [email protected]

tnextday avatar Aug 22 '22 08:08 tnextday

I don't think this resolves the issue? Under which conditions is the path empty?

discordianfish avatar Aug 22 '22 14:08 discordianfish

Under which conditions is the path empty?

zfs removed /proc/spl/kstat/zfs/*/io in new versions . https://github.com/aristocratos/btop/issues/383

I don't think this resolves the issue?

Yes, it can't get IO metrics, but it can get zpool state, which is very useful for failure alerting.

https://github.com/prometheus/node_exporter/issues/2068#issuecomment-1160638681

tnextday avatar Aug 22 '22 14:08 tnextday

Gotcha, makes sense!

discordianfish avatar Sep 02 '22 11:09 discordianfish

Hello there. Any reason this PR is not merged yet ? This issue is a real pain for admins of ZFS file servers, as we have lost a lot of useful metrics since the ZFS update broke the exporter.

setaou avatar Sep 22 '22 15:09 setaou

I'm going to work on a new 1.4.0 release candidate tomorrow.

SuperQ avatar Sep 22 '22 17:09 SuperQ