node_exporter icon indicating copy to clipboard operation
node_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

fix cpustat when some cpus are offline

Open alexjx opened this issue 2 years ago • 1 comments

This is related to https://github.com/prometheus/procfs/pull/438.

We have a case that some of the CPU (threads) are offline intentionally. But due to procfs is returning interpolated values, which makes our cpu caculation return invalid values.

This patch pickup the new procfs change.

alexjx avatar Mar 15 '22 09:03 alexjx

But it needs rebasing

discordianfish avatar Jul 25 '22 16:07 discordianfish

Ping, can you please update this PR?

SuperQ avatar Sep 24 '22 08:09 SuperQ

This patch needs new procfs one, which has not yet been merged. I will push that one first.

alexjx avatar Sep 27 '22 07:09 alexjx

This patch has aligned with procfs@master. Please review. Thanks.

alexjx avatar Sep 30 '22 01:09 alexjx

gentle ping :)

mihalicyn avatar Jan 18 '23 15:01 mihalicyn

I think I have updated it. is it outdated?

alexjx avatar Jan 18 '23 15:01 alexjx

@alexjx ping to maintainers ;-)

cc @SuperQ

mihalicyn avatar Jan 18 '23 15:01 mihalicyn

This needs a rebase.

SuperQ avatar Jan 18 '23 16:01 SuperQ

The branch has rebase to latest master. Please help review. Thanks.

alexjx avatar Jan 20 '23 01:01 alexjx

Thanks!

mihalicyn avatar Jan 20 '23 11:01 mihalicyn