node_exporter icon indicating copy to clipboard operation
node_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

[RFE] Support OpenBSD 'CP_SPIN' CPU state in some way

Open siebenmann opened this issue 5 years ago • 2 comments

In 2018, OpenBSD introduced a new (system) CPU state, CP_SPIN, that counts time the system is stuck spinning on a lock: https://marc.info/?l=openbsd-cvs&m=152630109526317&w=2

The node exporter currently doesn't know about this state, which means that on relevant OpenBSD versions its node_cpu_seconds_total figures are incomplete and break various assumptions that people using them may have (for example, that the total of everything for a single CPU sums to more or less 1). If you want to limit to building on only the currently supported OpenBSD versions, this is straightforward, since both of them should have CP_SPIN and collector/cpu_openbsd.go can just use it.

(I would be happy to prepare a pull request with this small change.)

siebenmann avatar Mar 26 '20 16:03 siebenmann

@siebenmann Interesting! Yeah happy to review you PR!

discordianfish avatar Apr 17 '20 08:04 discordianfish

The current state is that OpenBSD AMD64 now supports SPIN since commit f8609aeee232d0deec8d90fbd4538f36225eb963. Other architectures are still lacking support, but that will probably be resolved when pull https://github.com/prometheus/node_exporter/pull/1971 lands.

siebenmann avatar Jun 04 '21 14:06 siebenmann

Hmm, I think this can be closed now.

rexagod avatar Mar 19 '24 20:03 rexagod