jmx_exporter icon indicating copy to clipboard operation
jmx_exporter copied to clipboard

Added option to scrape all types of attributes

Open umutsahin opened this issue 2 years ago • 2 comments

Hi @fstab, @tomwilkie

The reason I have created this PR is while scraping JMX metrics from apache ignite, if I used JMXMetricsSpi, exporter was not able to parse any of the metrics provided by specific SPI. The Attributes are returned as POJOs instead of the expectation Attribute implementation.

I have added an option to scrape everything from JMX, current implementation scrapes Attribute instances only. Config key: scrapeAllAttributes

Signed-off-by: Umut Sahin [email protected]

umutsahin avatar Nov 09 '22 14:11 umutsahin

Hi @dhoard, is there anything missing from my side to get this PR merged ? Thanks!

umutsahin avatar Apr 05 '23 06:04 umutsahin

@umutsahin I don't see any JUnit tests for the changes. (I'm working on a robust integration test suite.)

dhoard avatar Apr 06 '23 01:04 dhoard