jmx_exporter icon indicating copy to clipboard operation
jmx_exporter copied to clipboard

Use artifactId to generate debian package name

Open Skunnyk opened this issue 4 years ago • 1 comments
trafficstars

  • Since 77a5b8fe17520a097429cf5f47021990c0eb6438, "name" is "Prometheus JMX Exporter - Http Server", which break debian package generation
  • use artifactId to get a correct name

Skunnyk avatar Nov 08 '21 16:11 Skunnyk

This restore previous behavior, otherwise the package is not installable on debian systems:

dpkg: error processing archive /home/build/jmx_prometheus_httpserver-0.16.1.deb (--install):
 parsing file '/var/lib/dpkg/tmp.ci/control' near line 1:
 invalid package name (character ' ' not allowed (only letters, digits and characters '-+._'))

Skunnyk avatar Nov 08 '21 16:11 Skunnyk

It would bee great to get this merged. We prefer installing debian packages over hand crafting installations, but this bug is preventing us from using newer versions of jmx exporter.

ghost avatar Oct 06 '22 10:10 ghost

Hi :)

Is it possible for this PR to be merged ? This is really a small change affecting debian package build (which is advertised in the README), and it would be super awesome to have it fixed for the next release :pray:

Skunnyk avatar Feb 20 '23 17:02 Skunnyk

Thanks a lot for the reminder and for the PR, it's merged now.

fstab avatar Mar 06 '23 16:03 fstab