jmx_exporter icon indicating copy to clipboard operation
jmx_exporter copied to clipboard

Logging level to SEVERE for Exception

Open shaipan opened this issue 4 years ago • 3 comments
trafficstars

Currently, all exceptions are logged as FINE level. The FINE level gives too much log. We should be having SEVERE level for Exceptions.

shaipan avatar May 07 '21 13:05 shaipan

Thanks for the PR. Did you get these exceptions in a real world scenario? If so, it would be interesting to hear what happened. I'd like to avoid spamming user's log files with SEVERE messages, and it's hard to decide what is severe without an actual example.

fstab avatar May 15 '21 20:05 fstab

Thanks for the PR. Did you get these exceptions in a real world scenario? If so, it would be interesting to hear what happened. I'd like to avoid spamming user's log files with SEVERE messages, and it's hard to decide what is severe without an actual example.

We are setting an VM option -Dsun.rmi.transport.tcp.responseTimeout=30000. And our scrapping interval is 25s. So if some bean is taking more time to scrap than the scrapping interval, we wanted to capture it in the logs so that the problem bean can be identified. But due to FINE logging, the logs generated are too much and we cant keep all the logs in the production environment. So wanted to keep only SEVERE logs. On seeing java.net.SocketTimeoutException we can know that this particular bean took more time than 30s.

shaipan avatar May 16 '21 01:05 shaipan

@shaipan what is the status of the PR? Can you resolve the changes as well as complete the checks (DCO)?

dhoard avatar Dec 22 '21 17:12 dhoard