golang-builder icon indicating copy to clipboard operation
golang-builder copied to clipboard

Remove the entrypoint from the interface

Open grobie opened this issue 8 years ago • 2 comments

I'd suggest to not set an entrypoint in the Dockerfile but leave that to the caller. The builder.sh script should be in the PATH so that one can run the docker container with docker run --rm prom/golang-builder:1.5.3-main builder.sh [options]. This will also allow to provide more than one command later, for diagnosis for example.

grobie avatar Apr 09 '16 08:04 grobie

We could yes, but it is already possible to execute another command by using the --entrypoint option.

sdurrheimer avatar Apr 09 '16 08:04 sdurrheimer

Yes, that's what I'm using right now. I've found making the entrypoint always explicit helps the future reader of commands and is also more consistent than to sometimes set the --entrypoint and to sometimes rely on a default not immediately apparent.

grobie avatar Apr 09 '16 08:04 grobie