prometheus
feat: implement support for http digest auth (resolve #352)
Implements #352. I'd need this in blackbox exporter. Let me know what you think! :-)
Digest auth can be tested against https://httpbin.org/#/Auth.
Not sure about the linting errors, perhaps someone could give me some assistance with that?
I don't see any major issues. I do wonder about if github.com/icholy/digest is the best library option for this. I haven't done any evaluation of what the available options are.
Can you describe why you picked this implementation?
Yeah, I was expecting a bit of discussion around this. I don't know about your requirements for pulling in new dependencies. I was hoping Go's standard lib had an implementation of digest auth, but turns out it doesn't. I picked icholy/digest, because it was the only client implementation I could find.