client_ruby icon indicating copy to clipboard operation
client_ruby copied to clipboard

Rubocop

Open lawrencejones opened this issue 5 years ago • 3 comments

It's often a good idea in open-source projects to provide automated code linting. Rubocop is a great gem that does this for Ruby and is highly customisable.

Is there any reason we wouldn't add this to make it easier for people to create code-style consistent PRs?

lawrencejones avatar Jun 16 '19 12:06 lawrencejones

So, historically... This

I agree it'd be a good idea to try to re-add it, though.

dmagliola avatar Jun 16 '19 12:06 dmagliola

That's fine, I can understand that. These style guidelines do change with time- for several reasons, this can be quite sensible.

Happy to take the hit to reintroduce things as I think we get several significant benefits from it. Coupled with dependabot, I can't see this situation replacing itself (also, my best guess is this author wasn't aware of the autocorrect, which massively reduces the maintenance burden).

Will open a PR with rubocop changes.

lawrencejones avatar Jun 16 '19 15:06 lawrencejones

Totally agreed, just thought I'd contribute how we got here

dmagliola avatar Jun 16 '19 16:06 dmagliola