client_java icon indicating copy to clipboard operation
client_java copied to clipboard

Add mechanism to mark Spans as "sampled for Exemplars"

Open jonatan-ivanov opened this issue 2 years ago • 2 comments
trafficstars

In case of server-side sampling, it is necessary to let the sampler know that certain spans should not be dropped because their traceId/spanId were used to create Exemplars. Right now, there is no mechanism that users could use to inject their own logic to signal that a Span was sampled for Exemplars.

Since a Span can be anything (various tracers), this can be tricky so if there is no good general solution for this, some guidance in the documentation (maybe with examples) would be great to guide the users if they should implement their own Sampler or should they add this behavior to their SpanContextSupplier.

jonatan-ivanov avatar May 26 '23 19:05 jonatan-ivanov

Great timing, I'm literally working on it right now. I'll give you an update next week.

fstab avatar May 26 '23 19:05 fstab

Any update on this?

0x006EA1E5 avatar Jun 13 '23 16:06 0x006EA1E5