client_java icon indicating copy to clipboard operation
client_java copied to clipboard

Provide JVM Mixin.

Open jeschkies opened this issue 5 years ago • 2 comments

This proposes a monitoring mixing based on the dashboard https://grafana.com/grafana/dashboards/3066 by @jotak.

The datasource is templated in addition to the original dashboard.

Outstanding:

  • [ ] Alerts
  • [ ] CI integration

jeschkies avatar Oct 08 '20 12:10 jeschkies

There are jsonnet formatting and linting tools. However, they require go. How should I integrate them? Also, should I provide an example service?

jeschkies avatar Oct 08 '20 12:10 jeschkies

Thanks for your PR. I'm not sure it makes sense to define alerts and dashboards for a client library, the Java build ecosystem is fun enough without mixing in a completely different language in, and I'm overall not looking to add more to maintain to this repo.

I'd suggest putting this in some 3rd party repo and we could link from the readme for it. I also note that raw counters aren't useful to graph, you should be taking a rate of the GC count.

brian-brazil avatar Oct 09 '20 09:10 brian-brazil

Won't do

jeschkies avatar Nov 10 '22 16:11 jeschkies