client_golang icon indicating copy to clipboard operation
client_golang copied to clipboard

Add `ScrapeAndCompare` utility

Open bwplotka opened this issue 3 years ago • 2 comments

See https://github.com/kubernetes/kubernetes/pull/108277

Ideally we have method for comparing expected output with HTTP scrape, or at least body response form scrape.

Optionally:

  • We could also learn from utils https://github.com/kubernetes/component-base/blob/master/metrics/testutil/testutil.go#L48 and add some of them to client_golang

cc @kakkoyun @saswatamcode

bwplotka avatar Mar 04 '22 11:03 bwplotka

Hello 👋 Looks like there was no activity on this issue for the last 3 months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next 4 weeks, this issue will be closed (we can always reopen an issue if we need!).

stale[bot] avatar Sep 20 '22 21:09 stale[bot]

@bwplotka i think we can resolve this now

sazary avatar Oct 04 '22 21:10 sazary

Hello 👋 Looks like there was no activity on this issue for the last 3 months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next 4 weeks, this issue will be closed (we can always reopen an issue if we need!).

stale[bot] avatar May 21 '23 21:05 stale[bot]

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] avatar Sep 17 '23 06:09 stale[bot]