client_golang icon indicating copy to clipboard operation
client_golang copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

[CI]: Add Concurrency Grouping to GitHub Workflows

Open Ishani217 opened this issue 1 year ago • 1 comments

What problem is this PR solving?

fixes https://github.com/prometheus/client_golang/issues/1437

Description of the changes

  • Whenever we push commits to a PR, workflows are triggered for that commit. After that, if we push additional commits to this PR, workflows in Github Actions run on both commits.
  • We need to cancel the previous run and run only on the most recent pushed commit. This would help save some GitHub Action Minutes (probably not a problem for this project but its always better to same some resources) and unexpected workflow failures on previous commits.

Ishani217 avatar Feb 03 '24 04:02 Ishani217

@ArthurSens Nice catch actually :) If two PRs would be merged in a timeframe when their workflow runs are concurrent, then yes, previous PR's commit push workflow trigger would be cancelled.

I need to close this PR then, since we aren't using merge queues to handle that case

Ishani217 avatar Feb 19 '24 08:02 Ishani217