blackbox_exporter
blackbox_exporter copied to clipboard
prometheus
Adding unix sockets support
Hello, I'm currently using Blackbox exporter and I need to expose endpoints though Unix Sockets. This could be useful for many people because we can set file ACLs on Unix Sockets and so preventing unauthorized users from accessing the service, and it requires only adding few lines since UNIX socket support is a built-in in Golang. I have already tested the code, and it works well.
Signed-off-by: Ismail [email protected]
This has been discussed before and we did not reach a consensus in Prometheus team whether we want it or not.
Bump this one. This will really help if this code is merged upstream. I compiled it using the proposed patch and it's working well.
Why is this subject to discussion ? This does not implies any security issue, nor big code changes. This can be really helpful, especially when working with apparmor.
Nginx team did that in their exporter (https://github.com/nginxinc/nginx-prometheus-exporter) and I managed to use it exactly the way I want.
I can fix failed checks if you're okay to merge this one. If you have more questions, I would be happy to answer them !
