blackbox_exporter icon indicating copy to clipboard operation
blackbox_exporter copied to clipboard

Move from Circle CI to Github Actions

Open electron0zero opened this issue 11 months ago • 4 comments

I see that prometheus moved away from Circle CI to Github Actions in https://github.com/prometheus/prometheus/pull/11235, and similar discussion is going on for statsd_exporter in https://github.com/prometheus/statsd_exporter/issues/604

opened this issue to have a place of discussion for the migration.

if team is okay with the migration, I intend to find some time and start the migration

Sidenote: GRPC tests have been failing on master

Why migrate?

  • https://github.com/prometheus/prometheus/pull/11235 shows that prometheus migrated 2 years ago
  • Other exporters are also migrating to GitHub Actions
  • GitHub actions is one less service to login into, and easy to view CI logs

Possible blockers:

  • IPV6 tests in GitHub Actions: https://github.com/actions/runner-images/issues/668 (but we should be able to it get it working like we do it in CircleCI or like this https://github.com/PowerDNS/pdns/pull/12856)

electron0zero avatar Dec 24 '24 18:12 electron0zero

few more datapoints:

  • influxdb_exporter moved to GitHub Actions in commit cfec208

  • exporter-toolkit moved to GitHub Actions in commit c3bf1e8

  • promlens - only has github actions

electron0zero avatar Dec 27 '24 13:12 electron0zero

@electron0zero I am happy to give this issue a shot if you've not started working on it already.

bryce-souers avatar Jan 03 '25 07:01 bryce-souers

@Bryce-Souers nope I haven't started it yet so go for it

electron0zero avatar Jan 03 '25 10:01 electron0zero

@electron0zero I have submitted #1351, please let me know if this works for the issue.

bryce-souers avatar Jan 05 '25 02:01 bryce-souers