blackbox_exporter icon indicating copy to clipboard operation
blackbox_exporter copied to clipboard
verified publisher icon prometheus

Fixed target parsing

Open Astrarog opened this issue 2 years ago • 3 comments

Improved http(s) scheme check so that target may be passed in lower and upper cases.

Before the fix works only schemes:

  • http://
  • https://

After the fix also works schemes alike:

  • HTTPS://
  • HtTp://

Astrarog avatar Oct 14 '23 12:10 Astrarog

Hi, @electron0zero ! I've added different tests cases and looks like they've all passed.

Astrarog avatar Nov 25 '24 04:11 Astrarog

Hi, @electron0zero ! I've added different tests cases and looks like they've all passed.

@Astrarog the CI has been failing, can you sync your fork, and rebase the PR please. will merge once CI is green ✅

electron0zero avatar Nov 27 '24 10:11 electron0zero

Hi, @electron0zero ! I've added different tests cases and looks like they've all passed.

@Astrarog the CI has been failing, can you sync your fork, and rebase the PR please. will merge once CI is green ✅

The fork is synced already. In CI failing test which are GRPC related. I believe that this fix doesn't correlate with GRPC functions and test

Astrarog avatar Nov 27 '24 12:11 Astrarog