alertmanager icon indicating copy to clipboard operation
alertmanager copied to clipboard

Improve silence benchmarks

Open ultrotter opened this issue 1 month ago • 1 comments

  • Add some benchmarks for GC
  • Add benchmarks that call Mutes while adding some silences, to better test how it would be called in the real world
  • Change the existing Mutes test to have some matching and some non-matching silences, to be more realistic to how things would look in a real alertmanager
  • Pass a NoOpLogger to quartz to make the tests less noisy
  • Use Set() to add silences instead of pushing them onto the state

ultrotter avatar Nov 10 '25 11:11 ultrotter

GC Benchmarks are a bit slow. Options:

  1. Move them to a separate file with a -slow tag so that one can run them less often/on demand more easily
  2. Include the whole loop in the timer, which would measure also the snapshot load, other than the GC
  3. Look into speeding up the setup we do?

Any preferences?

ultrotter avatar Nov 10 '25 13:11 ultrotter