alertmanager icon indicating copy to clipboard operation
alertmanager copied to clipboard

Add silence logging option

Open anarcat opened this issue 11 months ago • 8 comments

Past silences are really important to postmortem our alert management operations. We need to get "when" and "what kind of" create/edit/delete silences. So this PR added optional function that logging silence change.

Reroll of #2536 to address review item.

anarcat avatar Dec 17 '24 17:12 anarcat

Needs a rebase.

SuperQ avatar Oct 19 '25 09:10 SuperQ

i rebased, but the history is not super clean, should i squash?

anarcat avatar Nov 14 '25 17:11 anarcat

Squashing the commit sounds like a good idea to me. Just a question would it make sense to add a minimal test for the new function?

TheMeier avatar Nov 14 '25 19:11 TheMeier

probably! not sure where to start with that though

anarcat avatar Nov 14 '25 20:11 anarcat

How about something like this https://github.com/TheMeier/alertmanager/commit/ada4ea8dc92d4464810ab23d80b09ab69f29ccfd

TheMeier avatar Nov 17 '25 17:11 TheMeier

How about something like this TheMeier@ada4ea8

that looks fantastic.

anarcat avatar Nov 17 '25 18:11 anarcat

So how about you steal it into your branch and then squash everything ;)

TheMeier avatar Nov 17 '25 18:11 TheMeier

So how about you steal it into your branch and then squash everything ;)

done!

... and rebased.

anarcat avatar Nov 17 '25 18:11 anarcat