alertmanager icon indicating copy to clipboard operation
alertmanager copied to clipboard

Muted alerts are supressed and add "mutedBy" to APIv2

Open grobinson-grafana opened this issue 1 year ago • 4 comments

This commit updates TimeMuteStage to mark muted alerts as suppressed, and adds the names of all mutes that mute the alert to a field called mutedBy. This field is also returned in APIv2.

Fixes #3513

grobinson-grafana avatar Sep 13 '23 08:09 grobinson-grafana

Should I also update apiv1? I'm not sure if that's in maintenance mode or still receiving features?

grobinson-grafana avatar Sep 13 '23 08:09 grobinson-grafana

I chatted with George offline for a bit, and it turns out this doesn't do what he thought it did. It suffers from a "race" where an alert from one route can override the status from the same alert going through another way.

Because time intervals are at a route level, the filtering must show on which route was the time interval active so that underlying data structure needs to change to accommodate that requirement.

gotjosh avatar Oct 13 '23 15:10 gotjosh

I've decided to make this a draft for the time being as there is a lot of work still to do and there are still some decisions to make about how to best add this feature.

grobinson-grafana avatar Oct 20 '23 09:10 grobinson-grafana

Hey team! Is there any progress on this task?

thank you!

jasuade avatar Feb 19 '24 11:02 jasuade

I'm closing this to start over, as it's been almost 6 months since we last worked on it. There are some conflicts with main that I need to fix, and I am considering doing something a little different this time.

grobinson-grafana avatar Mar 01 '24 10:03 grobinson-grafana