alertmanager icon indicating copy to clipboard operation
alertmanager copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

asset: use embed over vfsdata implementation

Open jan--f opened this issue 2 years ago • 8 comments

This replicates work done in the prometheus repo in https://github.com/prometheus/prometheus/pull/10220 plus a few follow up PRs. Asset compression is handled via https://github.com/prometheus/common/tree/main/assets

Signed-off-by: Jan Fajerski [email protected]

jan--f avatar Oct 25 '22 13:10 jan--f

Not really sure what I'm doing when it comes to circleCI. I'll keep working at it, but if anyone wants to help I'm all ears :ear:.

jan--f avatar Nov 04 '22 15:11 jan--f

Any chance of resurrecting this PR? Using the standard library embed would make Alertmanager quite a bit simpler to package in Debian, where shurcooL/vfsgen is not packaged.

dswarbrick avatar Aug 26 '23 14:08 dswarbrick

Rebased. I'd love to move this forward too. @roidelapluie approved this in prometheus, maybe he can help?

jan--f avatar Aug 28 '23 15:08 jan--f

Thanks very much @jan--f I'll take a look soon.

gotjosh avatar Sep 06 '23 10:09 gotjosh

Thanks, we probably want to figure out #3299 first, unless someone has good insight into circleCI.

jan--f avatar Sep 06 '23 10:09 jan--f

Should we resume here now @jan--f ?

gotjosh avatar Nov 01 '23 19:11 gotjosh

@gotjosh Absolutely, I might need a day or two to get to it.

jan--f avatar Nov 07 '23 07:11 jan--f

Seems like the circleci pipeline is running into https://discuss.circleci.com/t/orbs-cannot-find-a-definition-for-command-named/34530 We have build only defined as a job, but not as a command. Otoh github actions do not yet build the elm frontend and that will require some tweaking/addition of make targets.

@gotjosh wdyt...should I work on both fixing the circleci orb and the actions workflow or is there a reason to prioritize one over the other?

jan--f avatar Nov 13 '23 19:11 jan--f