feat: added newrelic receiver

[haihongren]

Hey guys

I am working for New Relic. I have added the code for the newrelic receiver. Could you please review the PR and advise me the next step.

Thanks, Haihong

[haihongren]

Hi @beorn7

I found your name from other PR. Could you please help to review this PR?

It passed all tests except "test_frontend". I think it is related to the change to "template/default.tmpl". Not sure how to fix it on my end. My local test passed successfully.

Thanks in advance! Haihong

[beorn7]

Thanks for your contribution.

However, I'm not the maintainer of this repo. I helped a bit on a best effort basis, but right now, I have zero time left to do things here.

@simonpasquier could you look at this or delegate?

[haihongren]

Thanks @beorn7

@simonpasquier Please advise when you have a chance. Thanks!

[haihongren]

I would review this later, in the mean time I have added a comment. it also seems that the documentation is completely missing.

@roidelapluie Thanks for pointing out the missing documentation. How do I provide the documentation? in what format?

[roidelapluie]

In markdown, in the docs/ directory

[haihongren]

@roidelapluie The New Relic receiver documentation is included in docs/configuration.md now. Thanks!

[haihongren]

@roidelapluie One of the customers really wants to have this feature merged into the master so that they could use in production. Could you please review at your earliest? Thanks.

[RichiH]

As a side note, could you please sign the DCO, @haihongren ?

[haihongren]

@RichiH Thanks for the comment. DCO signed for the commit.

[roidelapluie]

is it possible to have a test account at NR to test this?

[haihongren]

@roidelapluie I have added prometheus-team email address as an NR user. You should receive an email invite at the prometheus-team email account.

[haihongren]

@roidelapluie Is there anything else you need to proceed with the PR?

[roidelapluie]

Thanks! I finally have some time to dig into this.

Do you know how I can create an API key that works? I currently get 403 with the key I created.

[roidelapluie]

I also wonder if we should use the logs api or the incidents API.

[haihongren]

I also wonder if we should use the logs api or the incidents API.

@roidelapluie Logs api allows user to collect alerts, generate report/dashboard for alerts, even take further action if required.

I would avoid that and add the ability to pass the license key explicitly. We should not put that burden to users. @roidelapluie agreed. I removed the Headers setting option. User will use api_key to provide license key explicitly.

[Conejsksk]

Hi guys, any update on this?

[haihongren]

Hi, can someone please review the PR? thanks