prometheus-operator icon indicating copy to clipboard operation
prometheus-operator copied to clipboard

Add support for passing web.max-connections argument to Prometheus

Open vivekjainx86 opened this issue 3 years ago • 2 comments

What is missing? I didn't find any specification in PrometheusSpec to pass --web.max-connections=<integer> argument to Prometheus. Also, there is no support for passing configuration parameter to Prometheus which is not in PrometheusSpec.

Why do we need it? It will be helpful if PrometheusSpec has all the configuration parameters that Prometheus has, or at least there should be a way to provide additional configuration parameters.

Environment

  • Prometheus Operator version:

    v2.32.1

vivekjainx86 avatar Jun 14 '22 11:06 vivekjainx86

@vivekjainx86 would you like to contribute? :)

slashpai avatar Jun 14 '22 12:06 slashpai

or at least there should be a way to provide additional configuration parameters.

I've just filed #4851 which is about this use case as it was an action item from our last office hours meetings :)

simonpasquier avatar Jun 14 '22 12:06 simonpasquier

With #4851 being closed shouldn't this be closed as well? Or do we want dedicated support for this?

JoaoBraveCoding avatar Nov 17 '22 15:11 JoaoBraveCoding

I'd keep the issue opened. The CRD should eventually allow setting the parameter like this:

spec:
  web:
    maxConnections: 256

simonpasquier avatar Nov 17 '22 16:11 simonpasquier

You can try something like this. It works for me in the values.yaml for helm.

          prometheusSpec:
            additionalArgs:
            - name: web.max-connections
              value: "10000"

grv180290 avatar Oct 19 '23 16:10 grv180290