windows_exporter
windows_exporter copied to clipboard
prometheus-community
WDDM metrics
I'm opening a PR for feature that collects GPU metrics via WDDM in the perflib collector (initially the idea was to collect NVIDIA GPU metrics via NVML but that does not work with cards in WDDM mode, but that functionality is in this PR as well).
What is the best practice - should I squash the whole feature branch, merge it in my master, rebase it and then open a PR?
@carlpett thanks for getting back, so let's try and resolve the points and I'll fix the stuff that needs fixing :) Since I already made some bugfixes it actually became annoying that I have to build this from source every time and redistribute the binary, if the proper way would be to use the official releases. Btw one thing I stumbled upon last week - the promu build command actually silently excluded all the cgo stuff since the yaml file was missing:
go:
cgo: true
which I added. So up to this point windows_exporter did not anyhow depend on any C bindings?
So up to this point windows_exporter did not anyhow depend on any C bindings?
Hm. It does, eg for the container collector (although the cgo stuff itself is in a separate library). I wonder why this would work? Could we be using different versions of promu? I believe we pinned the version quite a while ago due to some bug in Promu, there might have been upstream changes since then :grimacing:
@okopanja I didn't manage to refactor/split all the stuff, and it seems like there is not much need for it, so I can just keep it as is in my local fork. Are you interested in it or just tidying up? In case of the former, I can try and finally make everything nice and repush, otherwise I guess this can be tidied up.
@okopanja I didn't manage to refactor/split all the stuff, and it seems like there is not much need for it, so I can just keep it as is in my local fork. Are you interested in it or just tidying up? In case of the former, I can try and finally make everything nice and repush, otherwise I guess this can be tidied up.
I'd love to see this PR pushed over the line
@ChandonPierre Hey, sorry for abandoning work on this - simply lack of time and it was easier to live with a local fork since the WDDM/GPU metrics were all that I needed, but can try to find time and give the refactor another go, but I can't make any promises on the timeline. Anyone else maybe interested in helping out?
Hi @rubu - do you have some time to finish this up? I am interested in having some gpu metrics on windows endpoints.
