validation issues in the metric format when checking against promtool

[kajanth]

Prometheus version : 2.22.1 Platform : Windows

curl -s http://localhost:9184/metrics | c:\prom\prometheus-2.22.1.windows-amd64\promtool.exe check metrics

process_start_time_seconds counter metrics should have "_total" suffix windows_container_available counter metrics should have "_total" suffix windows_container_count non-histogram and non-summary metrics should not have "_count" suffix windows_container_cpu_usage_seconds_kernelmode counter metrics should have "_total" suffix windows_container_cpu_usage_seconds_usermode counter metrics should have "_total" suffix windows_net_packets_outbound_discarded counter metrics should have "_total" suffix windows_net_packets_outbound_errors counter metrics should have "_total" suffix windows_net_packets_received_discarded counter metrics should have "_total" suffix windows_net_packets_received_errors counter metrics should have "_total" suffix windows_net_packets_received_unknown counter metrics should have "_total" suffix windows_process_handle_count non-histogram and non-summary metrics should not have "_count" suffix windows_process_thread_count non-histogram and non-summary metrics should not have "_count" suffix

[breed808]

Hi @kajanth, thanks for reporting this. It looks like some of these metrics (particularly the windows_container metrics) may be gauges, and need to be changed. Others appear to be counters that need the suffix corrected. I don't have the ability to confirm the container metrics, but I'll look into the others.

[mjtrangoni]

Update for windows_exporter v0.17.0 and prometheus v2.32.1 for the following collectors enabled cache,cpu,logical_disk,net,memory,os,process,system,tcp,time

# curl -s http://xxxx:9182/metrics | promtool check metrics
windows_cache_copy_read_hits_total non-counter metrics should not have "_total" suffix
windows_memory_cache_faults_total non-counter metrics should not have "_total" suffix
windows_memory_demand_zero_faults_total non-counter metrics should not have "_total" suffix
windows_memory_page_faults_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_bytes_total non-counter metrics should not have "_total" suffix
windows_memory_pool_paged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_operations_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_reads_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_writes_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_read_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_written_total non-counter metrics should not have "_total" suffix
windows_memory_transition_faults_total non-counter metrics should not have "_total" suffix
windows_memory_transition_pages_repurposed_total non-counter metrics should not have "_total" suffix
windows_memory_write_copies_total non-counter metrics should not have "_total" suffix
windows_process_handle_count non-histogram and non-summary metrics should not have "_count" suffix
windows_process_thread_count non-histogram and non-summary metrics should not have "_count" suffix
windows_tcp_connection_failures counter metrics should have "_total" suffix
windows_tcp_connections_active counter metrics should have "_total" suffix
windows_tcp_connections_passive counter metrics should have "_total" suffix
windows_tcp_connections_reset counter metrics should have "_total" suffix
windows_time_ntp_client_time_source_count non-histogram and non-summary metrics should not have "_count" suffix

I will check if I can fix somes for the next release

[mjtrangoni]

Update for the mssql collector, I will be submitting PR over sub collectors because of the amount of issues.

windows_mssql_accessmethods_au_batch_cleanup_failures counter metrics should have "_total" suffix
windows_mssql_accessmethods_au_batch_cleanups counter metrics should have "_total" suffix
windows_mssql_accessmethods_au_cleanups counter metrics should have "_total" suffix
windows_mssql_accessmethods_by_reference_lob_creates counter metrics should have "_total" suffix
windows_mssql_accessmethods_by_reference_lob_uses counter metrics should have "_total" suffix
windows_mssql_accessmethods_column_value_pulls counter metrics should have "_total" suffix
windows_mssql_accessmethods_column_value_pushes counter metrics should have "_total" suffix
windows_mssql_accessmethods_dropped_rowset_cleanups counter metrics should have "_total" suffix
windows_mssql_accessmethods_dropped_rowset_skips counter metrics should have "_total" suffix
windows_mssql_accessmethods_extent_allocations counter metrics should have "_total" suffix
windows_mssql_accessmethods_extent_deallocations counter metrics should have "_total" suffix
windows_mssql_accessmethods_forwarded_records counter metrics should have "_total" suffix
windows_mssql_accessmethods_free_space_page_fetches counter metrics should have "_total" suffix
windows_mssql_accessmethods_free_space_scans counter metrics should have "_total" suffix
windows_mssql_accessmethods_full_scans counter metrics should have "_total" suffix
windows_mssql_accessmethods_ghost_record_skips counter metrics should have "_total" suffix
windows_mssql_accessmethods_index_searches counter metrics should have "_total" suffix
windows_mssql_accessmethods_insysxact_waits counter metrics should have "_total" suffix
windows_mssql_accessmethods_leaf_page_cookie_failures counter metrics should have "_total" suffix
windows_mssql_accessmethods_leaf_page_cookie_uses counter metrics should have "_total" suffix
windows_mssql_accessmethods_lob_handle_creates counter metrics should have "_total" suffix
windows_mssql_accessmethods_lob_handle_destroys counter metrics should have "_total" suffix
windows_mssql_accessmethods_lob_read_aheads counter metrics should have "_total" suffix
windows_mssql_accessmethods_lob_ss_provider_creates counter metrics should have "_total" suffix
windows_mssql_accessmethods_lob_ss_provider_destroys counter metrics should have "_total" suffix
windows_mssql_accessmethods_lob_ss_provider_truncations counter metrics should have "_total" suffix
windows_mssql_accessmethods_mixed_page_allocations counter metrics should have "_total" suffix
windows_mssql_accessmethods_page_allocations counter metrics should have "_total" suffix
windows_mssql_accessmethods_page_compression_attempts counter metrics should have "_total" suffix
windows_mssql_accessmethods_page_compressions counter metrics should have "_total" suffix
windows_mssql_accessmethods_page_deallocations counter metrics should have "_total" suffix
windows_mssql_accessmethods_page_splits counter metrics should have "_total" suffix
windows_mssql_accessmethods_probe_scans counter metrics should have "_total" suffix
windows_mssql_accessmethods_range_scans counter metrics should have "_total" suffix
windows_mssql_accessmethods_scan_point_revalidations counter metrics should have "_total" suffix
windows_mssql_accessmethods_table_lock_escalations counter metrics should have "_total" suffix
windows_mssql_accessmethods_tree_page_cookie_failures counter metrics should have "_total" suffix
windows_mssql_accessmethods_tree_page_cookie_uses counter metrics should have "_total" suffix
windows_mssql_accessmethods_workfile_creates counter metrics should have "_total" suffix
windows_mssql_accessmethods_worktables_creates counter metrics should have "_total" suffix
windows_mssql_accessmethods_worktables_from_cache_hits counter metrics should have "_total" suffix
windows_mssql_accessmethods_worktables_from_cache_lookups counter metrics should have "_total" suffix
windows_mssql_availreplica_flow_control_wait_seconds counter metrics should have "_total" suffix
windows_mssql_availreplica_initiated_flow_controls counter metrics should have "_total" suffix
windows_mssql_availreplica_received_from_replica_bytes counter metrics should have "_total" suffix
windows_mssql_availreplica_receives_from_replica counter metrics should have "_total" suffix
windows_mssql_availreplica_resent_messages counter metrics should have "_total" suffix
windows_mssql_availreplica_sends_to_replica counter metrics should have "_total" suffix
windows_mssql_availreplica_sends_to_transport counter metrics should have "_total" suffix
windows_mssql_availreplica_sent_to_replica_bytes counter metrics should have "_total" suffix
windows_mssql_availreplica_sent_to_transport_bytes counter metrics should have "_total" suffix
windows_mssql_bufman_background_writer_pages counter metrics should have "_total" suffix
windows_mssql_bufman_checkpoint_pages counter metrics should have "_total" suffix
windows_mssql_bufman_extension_page_evictions counter metrics should have "_total" suffix
windows_mssql_bufman_extension_page_reads counter metrics should have "_total" suffix
windows_mssql_bufman_extension_page_writes counter metrics should have "_total" suffix
windows_mssql_bufman_free_list_stalls counter metrics should have "_total" suffix
windows_mssql_bufman_lazywrites counter metrics should have "_total" suffix
windows_mssql_bufman_page_lookups counter metrics should have "_total" suffix
windows_mssql_bufman_page_reads counter metrics should have "_total" suffix
windows_mssql_bufman_page_writes counter metrics should have "_total" suffix
windows_mssql_bufman_read_ahead_issuing_seconds counter metrics should have "_total" suffix
windows_mssql_bufman_read_ahead_pages counter metrics should have "_total" suffix
windows_mssql_databases_backup_restore_operations counter metrics should have "_total" suffix
windows_mssql_databases_bulk_copy_bytes counter metrics should have "_total" suffix
windows_mssql_databases_bulk_copy_rows counter metrics should have "_total" suffix
windows_mssql_databases_dbcc_logical_scan_bytes counter metrics should have "_total" suffix
windows_mssql_databases_group_commit_stall_seconds counter metrics should have "_total" suffix
windows_mssql_databases_log_cache_reads counter metrics should have "_total" suffix
windows_mssql_databases_log_flush_waits counter metrics should have "_total" suffix
windows_mssql_databases_log_flushed_bytes counter metrics should have "_total" suffix
windows_mssql_databases_log_flushes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_cache_misses counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_disk_reads counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_empty_free_pool_pushes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_hash_deletes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_hash_inserts counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_invalid_hash_entries counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_log_scan_pushes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_log_writer_pushes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_low_memory_pushes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_no_free_buffer_pushes counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_req_behind_trunc counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_requests counter metrics should have "_total" suffix
windows_mssql_databases_log_pool_requests_old_vlf counter metrics should have "_total" suffix
windows_mssql_databases_repl_transactions counter metrics should have "_total" suffix
windows_mssql_databases_shrink_data_movement_bytes counter metrics should have "_total" suffix
windows_mssql_databases_tracked_transactions counter metrics should have "_total" suffix
windows_mssql_databases_transactions counter metrics should have "_total" suffix
windows_mssql_databases_write_transactions counter metrics should have "_total" suffix
windows_mssql_databases_xtp_controller_log_processed_bytes counter metrics should have "_total" suffix
windows_mssql_dbreplica_database_initiated_flow_controls counter metrics should have "_total" suffix
windows_mssql_dbreplica_group_commits counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_compressed_bytes counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_compression_cachehits counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_compression_cachemisses counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_compressions counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_decompressed_bytes counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_decompressions counter metrics should have "_total" suffix
windows_mssql_dbreplica_log_received_bytes counter metrics should have "_total" suffix
windows_mssql_dbreplica_mirrored_write_transactions counter metrics should have "_total" suffix
windows_mssql_dbreplica_received_file_bytes counter metrics should have "_total" suffix
windows_mssql_dbreplica_redo_blocks counter metrics should have "_total" suffix
windows_mssql_dbreplica_redone_bytes counter metrics should have "_total" suffix
windows_mssql_dbreplica_redones counter metrics should have "_total" suffix
windows_mssql_genstats_connection_resets counter metrics should have "_total" suffix
windows_mssql_genstats_logins counter metrics should have "_total" suffix
windows_mssql_genstats_logouts counter metrics should have "_total" suffix
windows_mssql_genstats_non_atomic_yields counter metrics should have "_total" suffix
windows_mssql_genstats_temp_tables_creations counter metrics should have "_total" suffix
windows_mssql_locks_count non-histogram and non-summary metrics should not have "_count" suffix
windows_mssql_locks_deadlocks counter metrics should have "_total" suffix
windows_mssql_locks_lock_requests counter metrics should have "_total" suffix
windows_mssql_locks_lock_timeouts counter metrics should have "_total" suffix
windows_mssql_locks_lock_timeouts_excluding_NOWAIT counter metrics should have "_total" suffix
windows_mssql_locks_lock_waits counter metrics should have "_total" suffix
windows_mssql_sqlstats_auto_parameterization_attempts counter metrics should have "_total" suffix
windows_mssql_sqlstats_batch_requests counter metrics should have "_total" suffix
windows_mssql_sqlstats_failed_auto_parameterization_attempts counter metrics should have "_total" suffix
windows_mssql_sqlstats_forced_parameterizations counter metrics should have "_total" suffix
windows_mssql_sqlstats_guided_plan_executions counter metrics should have "_total" suffix
windows_mssql_sqlstats_misguided_plan_executions counter metrics should have "_total" suffix
windows_mssql_sqlstats_safe_auto_parameterization_attempts counter metrics should have "_total" suffix
windows_mssql_sqlstats_sql_attentions counter metrics should have "_total" suffix
windows_mssql_sqlstats_sql_compilations counter metrics should have "_total" suffix
windows_mssql_sqlstats_sql_recompilations counter metrics should have "_total" suffix
windows_mssql_sqlstats_unsafe_auto_parameterization_attempts counter metrics should have "_total" suffix
windows_mssql_transactions_version_store_creation_units counter metrics should have "_total" suffix
windows_mssql_transactions_version_store_truncation_units counter metrics should have "_total" suffix
windows_mssql_transactions_version_store_units counter metrics should have "_total" suffix
windows_mssql_waitstats_lock_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_log_buffer_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_log_write_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_memory_grant_queue_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_network_io_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_nonpage_latch_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_page_io_latch_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_page_latch_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_thread_safe_memory_objects_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_transaction_ownership_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_wait_for_the_worker_waits counter metrics should have "_total" suffix
windows_mssql_waitstats_workspace_synchronization_waits counter metrics should have "_total" suffix

[github-actions[bot]]

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.