windows_exporter icon indicating copy to clipboard operation
windows_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus-community

scheduled_task: Move OLE connection to collect function

Open jkroepke opened this issue 10 months ago • 3 comments

Based on: https://github.com/influxdata/telegraf/blob/2de80263d5875531b5c39eb63c85b20109a35799/plugins/inputs/win_wmi/query.go#L77

Fixes #1425

jkroepke avatar Apr 21 '24 15:04 jkroepke

@mattdurham does fix the issue on your side?

Connecting to OLE during collect should also increase the support for multiple instances and reduce the locking to an minimum.

On my local system, I do not longer had issues.

jkroepke avatar Apr 21 '24 16:04 jkroepke

I think it should but will verify

mattdurham avatar Apr 25 '24 16:04 mattdurham

@mattdurham did you manage to verify the change?

breed808 avatar May 03 '24 04:05 breed808

@breed808 otherwise, if you agree - take a review and merge it.

It was wrong anyways to construct the OLE init on builder func. If the issue is not resolved, feedback can be applied in https://github.com/prometheus-community/windows_exporter/issues/1425

jkroepke avatar May 11 '24 10:05 jkroepke