windows_exporter icon indicating copy to clipboard operation
windows_exporter copied to clipboard

Version 0.25.X ignore enable_iis_worker_process

Open rivoalrivoal opened this issue 1 year ago • 3 comments

Hello

Since version 0.25, the w3wp doesn't have IIS Site name because of the EnableWorkerProcess variable. But, this variable doesn't work.

It's not because there are "kingpin" and not "app" here ?

https://github.com/prometheus-community/windows_exporter/blob/master/pkg/collector/process/process.go#L93C24-L93C31

My config file

collectors:
  enabled: cache,cpu,cpu_info,cs,iis,logical_disk,logon,memory,netframework_clrexceptions,netframework_clrinterop,netframework_clrjit,netframework_clrloading,netframework_clrlocksandthreads,netframework_clrmemory,netframework_clrremoting,netframework_clrsecurity,net,os,process,service,tcp,time,smtp

collector:
  process:
    enable_iis_worker_process: true

rivoalrivoal avatar Jan 17 '24 12:01 rivoalrivoal

And the windows_exporter --help does not indicate the option.

kago-dk avatar Jan 19 '24 21:01 kago-dk

Yes that seems to be the issue: https://github.com/prometheus-community/windows_exporter/blob/master/pkg/collector/process/process.go#L93C24-L93C31 should be app.Flag

But also just to mention, your config file should be:

collectors:
  enabled: cache,cpu,cpu_info,cs,iis,logical_disk,logon,memory,netframework_clrexceptions,netframework_clrinterop,netframework_clrjit,netframework_clrloading,netframework_clrlocksandthreads,netframework_clrmemory,netframework_clrremoting,netframework_clrsecurity,net,os,process,service,tcp,time,smtp

collector:
  process:
      iis: true

@breed808 I am going to create a PR to fix this. Ok ?

DiniFarb avatar Jan 29 '24 06:01 DiniFarb

Yep, go right ahead. I'm happy to review.

breed808 avatar Jan 29 '24 06:01 breed808

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

github-actions[bot] avatar Apr 29 '24 02:04 github-actions[bot]

Fixed in #1397

jkroepke avatar Apr 29 '24 18:04 jkroepke