pro-bing Per Probe/Packet Timeout Option

On go-ping this PR existed:

https://github.com/go-ping/ping/pull/202

It would be very usefull to have a packet timeout option on the Pinger in this package

Jan 23 '23 10:01 s00500

Yup! Absolutely something we want to implement.

Jan 23 '23 18:01 SuperQ

Hi! I'm interesting in either implementing this or rebasing https://github.com/go-ping/ping/pull/202/files into pro-bing.

Which way would you guys prefer?

Apr 03 '23 22:04 TheRushingWookie

It would need to fix the implementation issues of the original PR. As pointed out in several PRs to do per-packet timeouts, it needs to use a Go timer callback to accurately handle the timeouts, as well as not constantly sweep the packet tracking data.

I started working on refactoring the packet tracking in https://github.com/prometheus-community/pro-bing/pull/9. The intention was to make it easier to implement the per-packet timeouts.

Apr 04 '23 07:04 SuperQ

I'll take a look at #9 and https://github.com/go-ping/ping/pull/202

I think using a Go timer makes sense, though I'm not sure how expensive it is. I'll take a look at the implementation to make sure its cheap.

Apr 04 '23 16:04 TheRushingWookie

Yup! Absolutely something we want to implement.

May 19 '23 05:05 eysa12123