postgres_exporter icon indicating copy to clipboard operation
postgres_exporter copied to clipboard
verified publisher icon prometheus-community

fix #547

Open mblp opened this issue 2 years ago • 6 comments

mblp avatar Sep 16 '23 16:09 mblp

fix two issue #1794 and #547

mblp avatar Sep 16 '23 16:09 mblp

This needs a DCO sign-off. You can use git commit -s --amend to add it.

SuperQ avatar Sep 17 '23 09:09 SuperQ

@mblp Are you still interested in getting your PR merged? If not, I'd like to take care of this issue

saz avatar May 17 '24 09:05 saz

@saz Does this MR fixed #547?

This MR has been inactive for a quite while. Considering our need for a postgres_exporter tailored for Postgres 16, we might patch and build a custom version. If you're able to complete this MR and push it to the master branch, that would be fantastic.

nickaein avatar Jun 02 '24 11:06 nickaein

@saz I'll be glad if someone takes care of it. Unfortunately, I don't have time to figure out the correct design of MR.

mblp avatar Jun 19 '24 14:06 mblp

@nickaein LGTM. Maybe there's a new issue introduced, but I'd rather fix the ones I'm aware of, and the PR does exactly that.

@mblp Thanks, I'll do a new PR and will mention, that it's based on your work.

saz avatar Jun 20 '24 13:06 saz

What are we missing to get this merged?

scanterog avatar Aug 30 '24 16:08 scanterog

DCO to start.

SuperQ avatar Aug 30 '24 17:08 SuperQ

@SuperQ @scanterog See PR #1048

saz avatar Aug 30 '24 17:08 saz

Merged via #1048

sysadmind avatar Sep 05 '24 13:09 sysadmind