postgres_exporter icon indicating copy to clipboard operation
postgres_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus-community

Fix connection issue to multiple databases.

Open denisok opened this issue 2 years ago • 4 comments

This is merge and conflict resolution for #529, please read more details there.

closes https://github.com/prometheus-community/postgres_exporter/pull/529 https://github.com/prometheus-community/postgres_exporter/issues/528

Co-Authored-By: Andrii Skomorokhov [email protected] Signed-off-by: Denys Kondratenko [email protected]

denisok avatar Jun 23 '22 09:06 denisok

This needs a DCO sign-off. You can use git commit -s --amend to add it.

SuperQ avatar Jul 29 '22 10:07 SuperQ

I wonder if this is still a problem now that we've merged #618. But I think it makes sense to not keep idle connections open anyway.

SuperQ avatar Jul 29 '22 12:07 SuperQ

This needs a DCO sign-off. You can use git commit -s --amend to add it.

it does has sign-off, but I also added original author, so DCO probably don't recognize it.

denisok avatar Aug 10 '22 17:08 denisok

We faced the need to disable idle connections too, but due to the connection not releasing memory for some reason. Looking forward to this fix to be merged :)

ivyazmitinov avatar Sep 22 '22 09:09 ivyazmitinov

@SuperQ any advise how I can keep DCO happy and still have original author? image

denisok avatar Nov 16 '22 14:11 denisok

Faced a similar problem. Freezing the decision to merge is understandable, since there is no general good solution for this problem, and in case of re-creating the connection, it will increase processor usage.

rishat-ishbulatov avatar Dec 07 '22 11:12 rishat-ishbulatov

@SuperQ due to idle connections the DB can't be dropped: https://jira.percona.com/browse/PMM-7958

denisok avatar Dec 07 '22 16:12 denisok