postgres_exporter icon indicating copy to clipboard operation
postgres_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus-community

Update queries.yaml

Open ctouil opened this issue 2 years ago • 1 comments

ctouil avatar Mar 23 '22 07:03 ctouil

It's not clear what the intent of this PR is. The queries.yaml file is being deprecated in the near future.

sysadmind avatar Mar 23 '22 12:03 sysadmind

The intent of this PR is evidently to update the syntax from postgres 12 (and older) to postgres 13+ (noting postgres 15 is current now).

https://www.postgresql.org/docs/current/pgstatstatements.html

benjimin avatar Mar 06 '23 21:03 benjimin

It's not clear what the intent of this PR is. The queries.yaml file is being deprecated in the near future.

what does it mean? are you planning to remove the ability to run extra queries?

mcosta74 avatar May 04 '23 12:05 mcosta74

what does it mean? are you planning to remove the ability to run extra queries?

Correct. We plan to remove this feature entirely as we migrate each postgres feature collector to Go code. By moving the queries into Go, we can better support multiple versions of PostgreSQL automatically. This is how it's done in the MySQL exporter and it is a far better user experience.

Most of the use of queries.yaml (business metrics, not PostgreSQL server metrics) is actually better suited for the more generic sql_exporter.

SuperQ avatar May 04 '23 12:05 SuperQ

what does it mean? are you planning to remove the ability to run extra queries?

Correct. We plan to remove this feature entirely as we migrate each postgres feature collector to Go code. By moving the queries into Go, we can better support multiple versions of PostgreSQL automatically. This is how it's done in the MySQL exporter and it is a far better user experience.

Most of the use of queries.yaml (business metrics, not PostgreSQL server metrics) is actually better suited for the more generic sql_exporter.

So you're suggesting to NOT use custom queries but one instance of the sql_exporter to run business queries?

mcosta74 avatar May 04 '23 12:05 mcosta74

@mcosta74 That is correct.

sysadmind avatar May 09 '23 00:05 sysadmind

Thanks for the info. I'm trying sql_exporter and it's exactly what I was looking for.

==============

Massimo Costa

Il mar 9 mag 2023, 10:42 Joe Adams @.***> ha scritto:

@mcosta74 https://github.com/mcosta74 That is correct.

— Reply to this email directly, view it on GitHub https://github.com/prometheus-community/postgres_exporter/pull/625#issuecomment-1539232444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4I7OKMQ2SLJTPAR2YXMODXFH7P7ANCNFSM5RNFPUCA . You are receiving this because you were mentioned.Message ID: @.***>

mcosta74 avatar May 10 '23 04:05 mcosta74

queries.yaml is now deprecated. Updates should now go into the collector package.

SuperQ avatar Jun 22 '23 06:06 SuperQ