node-exporter-textfile-collector-scripts icon indicating copy to clipboard operation
node-exporter-textfile-collector-scripts copied to clipboard
verified publisher icon prometheus-community

smartmon.sh: Support sntrealtek device type

Open kjetijor opened this issue 1 year ago • 1 comments

sntrealtek is a NVMe device behind a Realtek RTL9210 USB to NVMe, output Looks like regular NVMe devices.

kjetijor avatar Feb 17 '24 06:02 kjetijor

The smartmon.sh script is essentially deprecated and superseded by smartmon.py. Since the smartmon.sh script will be removed at some point in future, do you wish to also add equivalent functionality to smartmon.py?

dswarbrick avatar Oct 21 '24 13:10 dswarbrick

Having looking briefly at smartmon.py, we wouldn't need to change that, as it uses different heuristics for deciding whether or not to probe a device. If smartmon.sh is "more or less" deprecated, we can probably just close this, and I'll move on to smartmon.py instead of patching on smartmon.sh.

kjetijor avatar Dec 21 '24 18:12 kjetijor