node-exporter-textfile-collector-scripts icon indicating copy to clipboard operation
node-exporter-textfile-collector-scripts copied to clipboard

Some disks doesnt report device speed correctly, crashing script execution

Open ARPABoy opened this issue 2 years ago • 1 comments

Some disks doesnt report device speed correctly when pd_device_speed metric assigns a string value: "Unknown" script execution crashes in that case assign a 0 speed value.

ARPABoy avatar Sep 02 '23 20:09 ARPABoy

My gut feeling is that transforming an "unknown" value to a value of zero is going to obscure cases where disks are spun-down, and truly have a rotational speed of zero. I think it would be better to simply omit the metric if it is not a valid numeric value (which can be tested with isnumeric()).

dswarbrick avatar May 08 '24 20:05 dswarbrick