monaco-promql icon indicating copy to clipboard operation
monaco-promql copied to clipboard

gh-pages automatically generated on every master push

Open celian-garcia opened this issue 4 years ago • 6 comments

Roughly, the idea is to add a job/pipeline in circle ci with this command flow :

npm install
npm run build
npm link
cd examples/angular-promql
npm install
npm link monaco-promql
npm install -g angular-cli-ghpages
npm run build -- --prod --base-href "https://prometheus-community.github.io/monaco-promql/"
ngh -d dist/angular-promql

So that the gh-pages would contains the latest code of monaco-promql. Not necessarily the released one but the master one.

celian-garcia avatar May 01 '20 10:05 celian-garcia

Necessit PR #4 to be merged to make the linking work

celian-garcia avatar May 01 '20 10:05 celian-garcia

Not necessary a good idea because gh-pages is the way to expose your project and will be the way for people to use it.

So if for any reason it's not stable, you will loose some people. I don't think using it as a "integration test" is the good way to use it.

Nexucis avatar May 02 '20 09:05 Nexucis

The idea here was just to automatize the generation of the gh-pages.

If you don't like to generate it from master we can then generate on tags I honestly don't really care and see any difference.

That said we need to find a way to control the display yes with kind of integration tests. Too bad you disagree because gh-pages was an easy way to achieve it... Maybe we can deploy several stuff in gh-pages...

celian-garcia avatar May 02 '20 11:05 celian-garcia

Yeah it's possible with subfolders, we can have :

  • under root ("/") : the latest deployed version, using a vanilla example
  • under angular ("/angular") : the latest deployed version, using angular as client
  • under react ("/react") : the latest deployed version, using react as client
  • under master ("/master") : one or several examples using master as source for the lib

It is possible using what is described in this gist https://gist.github.com/cobyism/4730490

celian-garcia avatar May 02 '20 11:05 celian-garcia

We can even use single-spa framework to have every example in the same webpage (angular + react + vanilla) it is possible.

celian-garcia avatar May 02 '20 11:05 celian-garcia

The idea to automatize is interesting. I would prefere to do it through a tag

Nexucis avatar May 03 '20 15:05 Nexucis