jiralert icon indicating copy to clipboard operation
jiralert copied to clipboard

Proposal: Move to Alertmanager.

Open bwplotka opened this issue 2 years ago • 11 comments

Given the popularity and use, I would like to propose pushing this code to Alertmanager notify package.

I got information AM maintainers will consider this (:

We need, however, maintainer for this notifier. Any volunteers? (:

bwplotka avatar Dec 22 '22 15:12 bwplotka

We also need official maintainer. I can co-maintain, but we need someone else to own this, so looking for volunteers (:

bwplotka avatar Feb 17 '23 09:02 bwplotka

@bwplotka What's involved with being the maintainer? I'm open to being co-maintainer at least.

twotired avatar May 12 '23 03:05 twotired

Just a general review of related PRs, issues and security fixes (:

Thanks, noted! Are you on the cncf slack?

bwplotka avatar May 17 '23 04:05 bwplotka

I am there, in the #jiralert channel

twotired avatar May 17 '23 04:05 twotired

I can help as maintainer as well if you still needed. I joined on slack channel #jiraalert

raonisiann avatar May 23 '23 09:05 raonisiann

I can help as maintainer aswell if help is needed. We use jiralert in a large environment.

holger-waschke avatar Jun 05 '23 14:06 holger-waschke

Amazing thanks! I think we have nice collection of contributors to attempt the move. Any of you would have time to prepare a PR to Alertmanager? I can even create feature branch for us. We can then together work towards PR with jiralert plugin in https://github.com/prometheus/alertmanager as well as documentation (: I will be there to consult and review (together with Alertmanager maintainers e.g. @simonpasquier)

bwplotka avatar Jun 09 '23 07:06 bwplotka

I was a little confused by what's needed here. I thought there was a need for additional maintainers of this project so that there could be a greater capacity to review and approve PRs and create new releases. Is that not in consideration?

I would be open to helping with the migration, but right now the priority for my team is to get some of the fixes in PRs into a new release. It is especially painful when we keep hitting the 32KB limit and JIRAs cannot be updated.

twotired avatar Jun 23 '23 02:06 twotired

Sorry for confusion, but as description suggests (https://github.com/prometheus-community/jiralert/issues/145#issue-1508084656) this issue is about proposing it to Alertmanager and maintaining similar code (with the same functionality) there (:

but right now the priority for my team is to get some of the fixes in PRs into a new release. It is especially painful when we keep hitting the 32KB limit and JIRAs cannot be updated.

Yup, feel free to propose changes to this repo for now. Whatever we do here will be useful in Alertmanager 👍🏽

bwplotka avatar Jun 23 '23 09:06 bwplotka

I've setup an PR on alertmanager

  • https://github.com/prometheus/alertmanager/pull/3590

jkroepke avatar Nov 12 '23 17:11 jkroepke

The PR is merged on AM site.

jkroepke avatar Aug 08 '24 07:08 jkroepke