ipmi_exporter icon indicating copy to clipboard operation
ipmi_exporter copied to clipboard

add test for SELEventsCollector

Open kmlebedev opened this issue 1 year ago • 1 comments

go test -v
=== RUN   TestCollectSELEventsCollector
--- PASS: TestCollectSELEventsCollector (0.00s)
PASS
ok      github.com/prometheus-community/ipmi_exporter   0.397s

kmlebedev avatar Dec 09 '24 11:12 kmlebedev

Thank you for your PR. Is there a specific reason you are wanting to test this? I am somewhat hesitant, because this would be mocking input where can't make any assertions about its format anyways (because parts of it are vendor-specifc, so all bets are off). I could maybe see how this might be useful to collect weird edge cases observed in the wild. Is there where this was going? If so, I'd be curious to hear about those first.

bitfehler avatar Feb 06 '25 09:02 bitfehler