helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[prometheus-systemd-exporter] Customize DaemonSet args

Open javiertury opened this issue 1 year ago • 0 comments
trafficstars

Is your feature request related to a problem ?

The args in the DaemonSet template are hardcoded and there is no way to change them

https://github.com/prometheus-community/helm-charts/blob/24979b1d1aee425312e039882de3d27c8fa9b607/charts/prometheus-systemd-exporter/templates/daemonset.yaml#L52-L54

Those values are very restrictive, since some kubernetes engines use other service names, e.g. k3s.service, or users may want to monitor additional service units as well. It would be much better if users could override args completely.

Describe the solution you'd like.

Being able to override args using values.yaml

Describe alternatives you've considered.

Adding my customization in extraArgs, but everything fails because --systemd.collector.unit-include can only be specified once.

Additional context.

No response

javiertury avatar Sep 28 '24 14:09 javiertury