helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon prometheus-community

Update kubernetes-apps.yaml

Open a7lan opened this issue 10 months ago • 1 comments

Update annotations to use dynamic time variables from the "for" key instead of hardcoded 15-min/1h durations.

Previously, time durations were hardcoded as 15 minutes/1h in various annotations. This commit replaces these static values with dynamic variables sourced from the "for" key. This change improves flexibility and maintainability, ensuring that the annotations accurately reflect configured time durations.

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • [ ] DCO signed
  • [ ] Chart Version bumped
  • [ ] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

a7lan avatar Apr 23 '24 13:04 a7lan

Hi,

thanks for you contribution. However all files insides rules-1.14 directory are auto-generated by an python script. In case I would merge this, the changes are getting reverted by next person who execution the script.

Please adjust the script https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/hack/sync_prometheus_rules.py to include your changes.

jkroepke avatar Apr 23 '24 13:04 jkroepke