helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[prometheus-json-exporter]: Allow additional container args and service monitor relabelings

Open faisal-khalique opened this issue 10 months ago • 1 comments

What this PR does / why we need it

  • Adds the option to pass arguments to the container. Could be needed for many reason. For example collecting logstash metrics with many pipelines where the pipeline definitions vary based on environment. Having the option of providing argument --config.file will greatly simplify such deployments. Considering future use cases, adding an array instead of just specifying the argument --config.file now
  • Add additional relabelings for service-monitor which can be used to drop unwanted labels from the metrics like container, pod, etc.

Special notes for your reviewer

Checklist

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

faisal-khalique avatar Mar 30 '24 23:03 faisal-khalique

@zanhsieh - can you please check this PR?

faisal-khalique avatar Apr 15 '24 13:04 faisal-khalique

Hey, what is the progress of this pr?

QuentinTournier40 avatar Jun 19 '24 12:06 QuentinTournier40