helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[kube-prometheus-stack] Add resources and SLIs metrics support

Open kariya-mitsuru opened this issue 1 year ago • 3 comments

What this PR does / why we need it

Add resources and SLIs metrics support.

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

kariya-mitsuru avatar Mar 04 '24 02:03 kariya-mitsuru

Is /metrics/cadvisor safe to remove? Are the metrics availible somewhere else, e.g. /metrics/resources? I also have to look later, if the current dashboards/alerts are compatible here.

I don't think /metrics/cadvisor can be removed because the metrics available in /metrics/cadvisor are different from those available in these endpoints.

kariya-mitsuru avatar Mar 04 '24 15:03 kariya-mitsuru

Hi @kariya-mitsuru

I appreciate your review, but currently I have time limitations to checkout and try-out this PR. I never used the endpoints before I someone might have to test it.

Maybe @QuentinBisson or @GMartinez-Sisti can assists here

jkroepke avatar Mar 28 '24 15:03 jkroepke

Hi @kariya-mitsuru

I appreciate your review, but currently I have time limitations to checkout and try-out this PR. I never used the endpoints before I someone might have to test it.

Maybe @QuentinBisson or @GMartinez-Sisti can assists here

Thanks for the PR @kariya-mitsuru 🙏 I actually have an upcoming project at work that will benefit from this, so I'll need to read on this. Might take some weeks for me to pick it up though.

GMartinez-Sisti avatar Apr 01 '24 08:04 GMartinez-Sisti