helm-charts
helm-charts copied to clipboard
[kube-prometheus-stack] Add resources and SLIs metrics support
What this PR does / why we need it
Add resources and SLIs metrics support.
-
KEP-1748: Expose Pod Resource Request Metrics
- kube-scheduler
-
KEP-3466: Kubernetes Component SLIs
- kube-apiserver
- kubelet
- kube-controller-manager
- kube-scheduler
- kube-proxy
Which issue this PR fixes
Special notes for your reviewer
Checklist
- [x] DCO signed
- [x] Chart Version bumped
- [x] Title of the PR starts with chart name (e.g.
[prometheus-couchdb-exporter]
)
Is
/metrics/cadvisor
safe to remove? Are the metrics availible somewhere else, e.g./metrics/resources
? I also have to look later, if the current dashboards/alerts are compatible here.
I don't think /metrics/cadvisor
can be removed because the metrics available in /metrics/cadvisor
are different from those available in these endpoints.
Hi @kariya-mitsuru
I appreciate your review, but currently I have time limitations to checkout and try-out this PR. I never used the endpoints before I someone might have to test it.
Maybe @QuentinBisson or @GMartinez-Sisti can assists here
Hi @kariya-mitsuru
I appreciate your review, but currently I have time limitations to checkout and try-out this PR. I never used the endpoints before I someone might have to test it.
Maybe @QuentinBisson or @GMartinez-Sisti can assists here
Thanks for the PR @kariya-mitsuru 🙏 I actually have an upcoming project at work that will benefit from this, so I'll need to read on this. Might take some weeks for me to pick it up though.