helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon prometheus-community

[kube-state-metrics] Default to Recreate

Open wiardvanrij opened this issue 6 months ago • 1 comments

What this PR does / why we need it

See issue/ticket.

Which issue this PR fixes

  • fixes #4095

Special notes for your reviewer

Checklist

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

wiardvanrij avatar Dec 18 '23 17:12 wiardvanrij

I would suggest to keep RollingUpdate as the default as well, rather than Recreating. If you run ksm with more than 1 replica, you have to deal with the instance in your query as well. If recreate fails for some reason and a rollback is needed, you will observe larger gaps in your metrics.

mrueg avatar Jan 09 '24 13:01 mrueg

Done in #4318

dotdc avatar Feb 29 '24 09:02 dotdc