helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[prometheus-consul-exporter] bump consul exporter to 0.13.0

Open DrFaust92 opened this issue 2 years ago • 6 comments

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

DrFaust92 avatar Sep 30 '23 15:09 DrFaust92

The values file needs to be amended as the exporter release 0.9 does not start with an invalid consulServer:

consulServer: host:port

As users set their own Consul server name, setting the default to localhost makes the exporter start successfully (and is a reasonable value afterall).

consulServer: "localhost:8500"

zeritti avatar Oct 01 '23 11:10 zeritti

@zeritti done, should this be considered a breaking change?

DrFaust92 avatar Oct 01 '23 12:10 DrFaust92

@zeritti done, should this be considered a breaking change?

In my opinion, no, not at all.

zeritti avatar Oct 01 '23 12:10 zeritti

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] avatar Mar 13 '24 10:03 stale[bot]

@zeritti any way we can merge this? other maintainers dont seem to respond 😊

DrFaust92 avatar May 05 '24 07:05 DrFaust92