[kube-prometheus-stack] New CRD subchart doesn't upgrade CRDs

[FireDrunk]

Describe the bug a clear and concise description of what the bug is.

The new CRDs in the crds subchart will only be installed when using helm install not when using helm upgrade. This was really hard to debug, and is extremely contradictory of what the chart should intend to do.

This issue was raised in the Helm repository as well: https://github.com/helm/helm/issues/11969

To the very least we should add this to the Upgrading documentation.

What's your helm version?

3.11

What's your kubectl version?

1.26.0

Which chart?

kube-prometheus-stack

What's the chart version?

48.2.2

What happened?

We were upgrading from 42.x to 48.x

What you expected to happen?

The CRDs should be upgraded when upgrading the Helm chart(s).

How to reproduce it?

Upgrade your Helm chart versions.

Enter the changed values of values.yaml?

n/a

Enter the command that you execute and failing/misfunctioning.

helm upgrade --install -f values.yaml .

Anything else we need to know?

No response

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[disconn3ct]

Stalebot should be considered harmful. This isn't a feature request. Bugs don't go away just because the developers can't be bothered to look at them.

/unstale if that wasn't obvious

[phyber]

Just upgraded my Helm charts, expecting the CRDs to be upgraded if crds.enabled was true. This didn't happen.

[santavizma]

SOLVED - manually deleted from cluster and applied by helm-chart.

Upgrading CRDS as well with Helm charts (to latest 56.6.2) and ArgoCD autoSync enabled, but we get error: rpc error: code = Internal desc = Failed to fetch default: git fetch origin --tags --force --prune failed exit status 1: error: cannot lock ref 'refs/tags/kube-prometheus-stack-51.7.0': Unable to create '..git/refs/tags/kube-prometheus-stack-51.7.0.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. From https://github.com/prometheus-community/helm-charts ! [new tag] kube-prometheus-stack-51.7.0 -> kube-prometheus-stack-51.7.0 (unable to update local ref)

crds.enabled are true by default

kube-prometheus-stack-56.6.2 was upgraded without issues.