helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[kube-prometheus-stack] Selectively enable Default Grafana Dashboards and allow annotations

Open martinrw opened this issue 1 year ago • 16 comments

Is your feature request related to a problem ?

I would like to be able choose which default dashboards to enable for grafana and have the ability to add annotations to them so that I can place them into specific folders.

Describe the solution you'd like.

For it to work selectively it would look somewhat similar to the default alert manager rules which are enabled like this:

defaultRules:
  create: true
  rules:
    alertmanager: true
    etcd: true
    configReloaders: false
    general: true

We could potentially take it one step further and then allow custom annotations for each one, in the end it would be enabled something like this:

defaultDashboards:
  create: true
  dashboards: 
    kubernetes_api_server:
      enabled: true
      annotations:
        - k8s-sidecar-target-directory: /tmp/dashboards/Kubernetes
    kubernetes_compute_resources_pod:
      enabled: true
      annotations:
        - k8s-sidecar-target-directory: /tmp/dashboards/Kubernetes

If you didn't specify an annotation it can just be set to {} or just not included at all

Describe alternatives you've considered.

none, I don't see any other approach at the moment other than copying the dashboard code and deploying them separately

Additional context.

No response

martinrw avatar Mar 27 '23 13:03 martinrw

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] avatar May 01 '23 17:05 stale[bot]

@martinrw FYI

banschikovde avatar May 02 '23 14:05 banschikovde

Thanks for commenting. I think this should remain open as I believe there is some value to this feature

martinrw avatar May 02 '23 15:05 martinrw

Would love this as well - currently everything gets deployed into the 'General' folder.

jeremych1000 avatar May 30 '23 17:05 jeremych1000

Same here, would be nice to be able to clean up and set a better folder layout suited to our orgs needs!

wonderphil avatar Jun 14 '23 12:06 wonderphil

+1 on this would love yo have it!

bsgrigorov avatar Jul 30 '23 09:07 bsgrigorov

+1

itswl avatar Aug 10 '23 07:08 itswl

+1 for this. Is there currently a way to at least customize the default 'General' to anything else now for all of them?

sonykphilip avatar Aug 10 '23 11:08 sonykphilip

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] avatar Sep 17 '23 06:09 stale[bot]

Commenting to un-stale

martinrw avatar Sep 17 '23 08:09 martinrw

+1 for this, please do not ignore this

OT: https://fvsch.com/stale-bots

korewaChino avatar Feb 25 '24 18:02 korewaChino

+1 for annotations

dehimb avatar May 16 '24 12:05 dehimb

+1, it would be useful to add annotations

jmischler72 avatar Jun 17 '24 12:06 jmischler72

+1, hope it will be added

abrahamdevops avatar Aug 15 '24 12:08 abrahamdevops