helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[kube-prometheus-stack] add recording and alerting switch to kubeScheduler

Open lusson-luo opened this issue 2 years ago • 6 comments

Signed-off-by: lusson [email protected]

What this PR does / why we need it

can disabled kubeScheduler alert or record alone, before kubeSchedulerAlert and kubeSchedulerRecord control by one switch kubeScheduler

Which issue this PR fixes

according to prs #2308 #2397

  • fixes #

Special notes for your reviewer

Checklist

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

lusson-luo avatar Aug 30 '22 03:08 lusson-luo

First-time contributors need a maintainer to

ok,i upgrade major version to 40.0.0

lusson-luo avatar Sep 05 '22 02:09 lusson-luo

See also: https://github.com/prometheus-community/helm-charts/pull/2410/files#L3

@monotek ok,i upgrade major version to 40.0.0

lusson-luo avatar Sep 15 '22 13:09 lusson-luo

Plaese raise version to 41.0.0

Readme needs upgrading instructions.

I would like to do this together with next prometheus operator update.

@monotek ok, thanks

  1. i raise version to 41.0.0
  2. The original readme no related configuration, so i think don't upgrading Readme.
  3. Okay, I'm waiting for other prometheus operator update.

lusson-luo avatar Sep 16 '22 12:09 lusson-luo

@monotek ok, thanks

  1. The original readme no related configuration, so i think don't upgrading Readme.

All major versions need an entry in the updating section, describing whats changed and what to do to get old behaviour.

monotek avatar Sep 16 '22 12:09 monotek

@monotek ok, thanks

  1. The original readme no related configuration, so i think don't upgrading Readme.

All major versions need an entry in the updating section, describing whats changed and what to do to get old behaviour.

understand, i add major versions updating section in readme

lusson-luo avatar Sep 16 '22 12:09 lusson-luo

@monotek readme has add empty line

lusson-luo avatar Sep 17 '22 09:09 lusson-luo